Comments on: DRYing up Rails Controllers: Polymorphic and Super Controllers

By: telefon dinleme

telefon dinleme — Sun, 09 Aug 2009 00:54:57 +0000

thank you for your article. i find it after to 1 month… good evening..

By: Swards

Swards — Sun, 28 Jun 2009 21:54:10 +0000

Great – All the ERB was removed. I’ll do a larger write up and post elsewhere – I’ll link back.

By: Swards

Swards — Sun, 28 Jun 2009 21:49:36 +0000

There’s a simpler way. If you make the comment form a partial and do this instead:

etc…

(Note the [@commentable, @comment])

‘comment_form’, :locals => { :commentable => @user} %>

You don’t need to deal with @klass, constantize, etc.

And, in the comments controller, do something like this:

def create
@comment = Comment.new(params[:comment])
@commentable = @comment.commentable
@comment.save
…
end

By: links for 2009-05-18 | NeXt

links for 2009-05-18 | NeXt — Wed, 17 Jun 2009 19:01:59 +0000

[...] Agile Ajax » DRYing up Rails Controllers: Polymorphic and Super Controllers » Pathfinder Developme… (tags: programming tutorial patterns agile controller ruby rails) [...]

By: huberto

huberto — Fri, 05 Jun 2009 00:37:39 +0000

thanks. this was just what i needed to get through my issue. i was thinking about doing something along these lines to dry up my controllers but felt that this might be a bit hackish and cause me great pain down the road. this reassures that’s not the case.

one thought though, wouldn’t something like this be cleaner?

in the view:

render :partial => ‘comments_form’ bject => @object_to_be_commented_on

and then call comments_form.class.to_s to generate the string constant from inside the comments_form partial?

-h

By: André Durão

André Durão — Mon, 25 May 2009 14:30:49 +0000

Hi there!
I found your topic very interesting, and help me a lot to understand polymorphism in rails..
I just got one question, maybe you know what I’m doing wrong:
In my case I would like to use a has_one instead of has_many in my models, but it didn’t worked, just with has_many it worked, is that some limitation of :as option?
thanks

By: Matt Simpson

Matt Simpson — Sun, 03 May 2009 08:01:54 +0000

Great article, just what I was looking for. Including all of the comments for how to enhance this method. My controllers are going to be beautifully DRY!

By: mitch

mitch — Tue, 24 Mar 2009 06:11:54 +0000

Nice discussion and examples. I do think dry can be taken too far when it means using inheritance just to isolate code. I mean, why should a User and a Meeting both inherit from the same class just because some of their methods have similar code? I agree that a module would be more appropriate.

By: nguma

nguma — Sat, 20 Dec 2008 21:37:25 +0000

When it comes down to polymorphism and routing,
there’s one really helpful trick:

polymorphic_url(@my_polymorphic_object)

it will redirect to the correct model, provided you have mapped its resources in routes.rb of course.

By: Brett Rasmussen

Brett Rasmussen — Fri, 24 Oct 2008 03:18:25 +0000

Josh, in your very first code snippet, you had

class Model < ActiveRecord::Base

but if I’m understanding all of this right, I think you meant

class Comment < ActiveRecord::Base

Also, in the first snippet under “Polymorphic Controllers”, you’re setting @klass as an instance variable in one line and then using it as just “klass” in the next line.

Just a couple of things I thought you might want to change for the sake of clarity to your readers. But thanks for the article; it was very useful to me.